Skip to content

Bump zeroconf, pychromecast. Log if zeroconf.get_service_info fails.#36185

Merged
cgarwood merged 1 commit intohome-assistant:devfrom
emontnemery:zc_deadlock
May 27, 2020
Merged

Bump zeroconf, pychromecast. Log if zeroconf.get_service_info fails.#36185
cgarwood merged 1 commit intohome-assistant:devfrom
emontnemery:zc_deadlock

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented May 27, 2020 •
edited by bdraco
Loading

Please see note about before cherry-picking to 0.110.4 #36185 (comment)

Proposed change

Bump zeroconf, pychromecast. Log if zeroconf.get_service_info fails.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@emontnemery emontnemery added this to the 0.110.4 milestone May 27, 2020
@probot-home-assistant probot-home-assistant Bot added core dependency Pull requests marked as a dependency upgrade integration: cast integration: zeroconf small-pr PRs with less than 30 lines. by-code-owner labels May 27, 2020
@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented May 27, 2020

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@cgarwood cgarwood merged commit c7e97f0 into home-assistant:dev May 27, 2020
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 28, 2020 •
edited
Loading

If this gets backported to 0.110.4, #35997 will need to come with it as 0.26.2 changed self.type (str) to self.types (list) or zeroconf discovery will be broken

@emontnemery emontnemery mentioned this pull request May 28, 2020
Merged
20 tasks
balloob pushed a commit that referenced this pull request May 28, 2020
@emontnemery @balloob
Bump zeroconf, pychromecast. Log if zeroconf.get_service_info fails. (#…
3a80cb1 
…36185)
@balloob balloob mentioned this pull request May 28, 2020
Merged
@bdraco bdraco mentioned this pull request Jun 3, 2020
Closed
@emontnemery emontnemery deleted the zc_deadlock branch June 10, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@robbiet480 robbiet480

@Kane610 Kane610

Labels

by-code-owner cherry-picked cla-signed core dependency Pull requests marked as a dependency upgrade integration: cast integration: zeroconf small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.110.4

Development

Successfully merging this pull request may close these issues.

Chromecast and Home-mini not detected after HA restart

7 participants

@emontnemery @bdraco @robbiet480 @balloob @cgarwood @homeassistant @Kane610